Bug 137270

Summary: Use is<>() / downcast<>() for ContainerNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2014-09-30 14:31:19 PDT 
Use is<>() / downcast<>() for ContainerNode instead of isContainerNode() / toContainerNode().
Comment 1 Chris Dumez 2014-09-30 14:38:50 PDT 
Created attachment 238964 [details]
Patch
Comment 2 Andreas Kling 2014-09-30 15:25:38 PDT 
Comment on attachment 238964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238964&action=review

r=me

> Source/WebCore/dom/Node.h:-745
> -// FIXME: This should be removed and all uses should be replaced with SPECIALIZE_TYPE_TRAITS_*().
> -#define NODE_TYPE_CASTS(ToClassName) \
> -    TYPE_CASTS_BASE(ToClassName, Node, node, WebCore::is##ToClassName(*node), WebCore::is##ToClassName(node))

Yay!
Comment 3 WebKit Commit Bot 2014-09-30 16:03:43 PDT 
Comment on attachment 238964 [details]
Patch

Clearing flags on attachment: 238964

Committed r174132: <http://trac.webkit.org/changeset/174132>
Comment 4 WebKit Commit Bot 2014-09-30 16:03:49 PDT 
All reviewed patches have been landed.  Closing bug.