Summary: | Web Inspector: ErrorString should be passed by reference | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, mkwst, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brian Burg
2014-09-30 11:26:22 PDT
Created attachment 238942 [details]
Patch
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Attachment 238942 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorReplayAgent.h:107: The parameter name "segmentState" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:114: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 72 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238942 [details]
Patch
r=me, nice little cleanups too (ASCIILiteral).
This was landed manually in <http://trac.webkit.org/changeset/174140>. |