Bug 137257

Summary: Web Inspector: ErrorString should be passed by reference
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Severity: Normal CC: commit-queue, graouts, joepeck, mkwst, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch joepeck: review+

Description Brian Burg 2014-09-30 11:26:22 PDT
Comment 1 Radar WebKit Bug Importer 2014-09-30 11:26:30 PDT
Comment 2 Brian Burg 2014-09-30 11:42:20 PDT
Created attachment 238942 [details]
Comment 3 WebKit Commit Bot 2014-09-30 11:44:34 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2014-09-30 11:44:50 PDT
Attachment 238942 [details] did not pass style-queue:

ERROR: Source/WebCore/inspector/InspectorReplayAgent.h:107:  The parameter name "segmentState" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:114:  The parameter name "pseudoIdMatches" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 72 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Joseph Pecoraro 2014-09-30 11:47:52 PDT
Comment on attachment 238942 [details]

r=me, nice little cleanups too (ASCIILiteral).
Comment 6 Brian Burg 2014-11-12 13:24:33 PST
This was landed manually in <http://trac.webkit.org/changeset/174140>.