Bug 137255

Summary:

Web Inspector: new breakpoint action dialog should reuse same action type

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, mattbaker, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

136292

Attachments:

Description	Flags
[Patch] Proposed Fix	none

Description Brian Burg 2014-09-30 10:55:10 PDT

When you add multiple actions to a breakpoint using the [+] button, the drop-down for action type always starts with the first value. It should copy the type of the previous action. This will make it less tedious to add multiple probes from the breakpoint actions dialog.

Comment 1 Radar WebKit Bug Importer 2014-09-30 10:55:35 PDT

<rdar://problem/18502769>

Comment 2 Matt Baker 2015-07-07 13:36:03 PDT

This would be different from Xcode's behavior, which defaults to Debugger Command every time. Their action list differs from ours, but I assume this is considered to be the most commonly used command (it's not the first in the list).

Comment 3 Timothy Hatcher 2015-07-07 13:40:18 PDT

Yeah, I think we should do this. I've considered a similar change in the past.

Comment 4 Matt Baker 2015-07-08 23:19:18 PDT

Created attachment 256462 [details]
[Patch] Proposed Fix

Comment 5 Brian Burg 2015-07-09 00:07:56 PDT

Comment on attachment 256462 [details]
[Patch] Proposed Fix

r=me

Comment 6 WebKit Commit Bot 2015-07-09 00:36:20 PDT

Comment on attachment 256462 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256462

Committed r186588: <http://trac.webkit.org/changeset/186588>

Comment 7 WebKit Commit Bot 2015-07-09 00:36:23 PDT

All reviewed patches have been landed.  Closing bug.