Bug 137255 - Web Inspector: new breakpoint action dialog should reuse same action type
Summary: Web Inspector: new breakpoint action dialog should reuse same action type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: WebReplayUI
  Show dependency tree / graph
 
Reported: 2014-09-30 10:55 PDT by Brian Burg
Modified: 2015-07-09 00:36 PDT (History)
6 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.67 KB, patch)
2015-07-08 23:19 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-30 10:55:10 PDT 
When you add multiple actions to a breakpoint using the [+] button, the drop-down for action type always starts with the first value. It should copy the type of the previous action. This will make it less tedious to add multiple probes from the breakpoint actions dialog.
Comment 1 Radar WebKit Bug Importer 2014-09-30 10:55:35 PDT 
<rdar://problem/18502769>
Comment 2 Matt Baker 2015-07-07 13:36:03 PDT 
This would be different from Xcode's behavior, which defaults to Debugger Command every time. Their action list differs from ours, but I assume this is considered to be the most commonly used command (it's not the first in the list).
Comment 3 Timothy Hatcher 2015-07-07 13:40:18 PDT 
Yeah, I think we should do this. I've considered a similar change in the past.
Comment 4 Matt Baker 2015-07-08 23:19:18 PDT 
Created attachment 256462 [details]
[Patch] Proposed Fix
Comment 5 Brian Burg 2015-07-09 00:07:56 PDT 
Comment on attachment 256462 [details]
[Patch] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2015-07-09 00:36:20 PDT 
Comment on attachment 256462 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256462

Committed r186588: <http://trac.webkit.org/changeset/186588>
Comment 7 WebKit Commit Bot 2015-07-09 00:36:23 PDT 
All reviewed patches have been landed.  Closing bug.