Bug 137251

Summary: Remove thirdparty/unittest2 from webkitpy
Product: WebKit Reporter: Éva Balázsfalvi <evab.u-szeged>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Éva Balázsfalvi
Reported 2014-09-30 06:34:37 PDT
Remove thirdparty/unittest2 from webkitpy
Attachments
Patch (119.28 KB, patch)
2014-09-30 09:24 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-09-30 09:24:13 PDT
Created attachment 238930 [details] Patch
Ryosuke Niwa
Comment 2 2014-09-30 09:38:41 PDT
What is the point of this patch? Why are we removing it? I thought we purposely started using unittest2 for some feature it provided.
Brent Fulgham
Comment 3 2014-09-30 16:27:11 PDT
Comment on attachment 238930 [details] Patch r=me. I had planned on proposing this patch today as well! Thanks for beating me to it! :-)
Brent Fulgham
Comment 4 2014-09-30 16:28:10 PDT
(In reply to comment #2) > What is the point of this patch? Why are we removing it? I thought we purposely started using unittest2 for some feature it provided. The "unites" that ships with Python 2.7 is the same as the "unittest2" stuff in our repository. So we are just getting rid of our custom local (probably outdated) version of this library in favor of the official version that now ships with Python.
Brent Fulgham
Comment 5 2014-09-30 16:32:45 PDT
From the documentation on "unittest2": "unittest2 is a backport of the new features added to the unittest testing framework in Python 2.7. It is tested to run on Python 2.4 - 2.7."
WebKit Commit Bot
Comment 6 2014-09-30 17:11:45 PDT
Comment on attachment 238930 [details] Patch Clearing flags on attachment: 238930 Committed r174136: <http://trac.webkit.org/changeset/174136>
WebKit Commit Bot
Comment 7 2014-09-30 17:11:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.