Summary: | Avoid copying the iterated-over items in range-based for-loops in RenderGrid | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2014-09-30 00:35:44 PDT
Created attachment 238913 [details]
Patch
Attachment 238913 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review > Source/WebCore/ChangeLog:9 > + of the items that are being iterated. Something wrong with the indentation here > Source/WebCore/rendering/RenderGrid.cpp:562 > + for (auto& trackIndex : sizingData.contentSizedTracksIndex) { This is just a size_t. I don't think we need this... Comment on attachment 238913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review >> Source/WebCore/ChangeLog:9 >> + of the items that are being iterated. > > Something wrong with the indentation here Tabs, somehow. >> Source/WebCore/rendering/RenderGrid.cpp:562 >> + for (auto& trackIndex : sizingData.contentSizedTracksIndex) { > > This is just a size_t. I don't think we need this... OK. Committed r174101: <http://trac.webkit.org/changeset/174101> |