Bug 137246 - Avoid copying the iterated-over items in range-based for-loops in RenderGrid
Summary: Avoid copying the iterated-over items in range-based for-loops in RenderGrid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 00:35 PDT by Zan Dobersek
Modified: 2014-09-30 05:50 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2014-09-30 00:41 PDT, Zan Dobersek 		svillar: review+
svillar: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-09-30 00:35:44 PDT 
Avoid copying the iterated-over items in range-based for-loops in RenderGrid
Comment 1 Zan Dobersek 2014-09-30 00:41:00 PDT 
Created attachment 238913 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-30 00:43:36 PDT 
Attachment 238913 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sergio Villar Senin 2014-09-30 03:36:04 PDT 
Comment on attachment 238913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review

> Source/WebCore/ChangeLog:9
> +	of the items that are being iterated.

Something wrong with the indentation here

> Source/WebCore/rendering/RenderGrid.cpp:562
> +    for (auto& trackIndex : sizingData.contentSizedTracksIndex) {

This is just a size_t. I don't think we need this...
Comment 4 Zan Dobersek 2014-09-30 04:31:27 PDT 
Comment on attachment 238913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review

>> Source/WebCore/ChangeLog:9
>> +	of the items that are being iterated.
> 
> Something wrong with the indentation here

Tabs, somehow.

>> Source/WebCore/rendering/RenderGrid.cpp:562
>> +    for (auto& trackIndex : sizingData.contentSizedTracksIndex) {
> 
> This is just a size_t. I don't think we need this...

OK.
Comment 5 Zan Dobersek 2014-09-30 05:50:04 PDT 
Committed r174101: <http://trac.webkit.org/changeset/174101>