Bug 137241

Summary:

Use is<>() / downcast<>() for Element

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137056

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2014-09-29 18:08:49 PDT

Use is<>() / downcast<>() for Element instead of isElementNode() / toElement().

Attachments
Patch (207.63 KB, patch) 2014-09-29 18:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (208.08 KB, patch) 2014-09-29 19:05 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (208.67 KB, patch) 2014-09-29 20:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2014-09-29 18:28:25 PDT

Created attachment 238900 [details] Patch

WebKit Commit Bot

Comment 2 2014-09-29 18:31:05 PDT

Attachment 238900 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLFormControlElement.h:195: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:914: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 4 in 108 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2014-09-29 19:05:56 PDT

Created attachment 238901 [details] Patch

WebKit Commit Bot

Comment 4 2014-09-29 19:09:18 PDT

Attachment 238901 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLFormControlElement.h:195: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:914: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 4 in 108 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 5 2014-09-29 20:22:28 PDT

Created attachment 238905 [details] Patch

WebKit Commit Bot

Comment 6 2014-09-29 20:24:20 PDT

Attachment 238905 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLFormControlElement.h:195: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:914: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 4 in 108 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 7 2014-09-30 12:22:11 PDT

Comment on attachment 238905 [details] Patch r=me

WebKit Commit Bot

Comment 8 2014-09-30 12:59:54 PDT

Comment on attachment 238905 [details] Patch Clearing flags on attachment: 238905 Committed r174117: <http://trac.webkit.org/changeset/174117>

WebKit Commit Bot

Comment 9 2014-09-30 12:59:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.