Bug 137241

Summary: Use is<>() / downcast<>() for Element
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-09-29 18:08:49 PDT 
Use is<>() / downcast<>() for Element instead of isElementNode() / toElement().
Comment 1 Chris Dumez 2014-09-29 18:28:25 PDT 
Created attachment 238900 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-29 18:31:05 PDT 
Attachment 238900 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-09-29 19:05:56 PDT 
Created attachment 238901 [details]
Patch
Comment 4 WebKit Commit Bot 2014-09-29 19:09:18 PDT 
Attachment 238901 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2014-09-29 20:22:28 PDT 
Created attachment 238905 [details]
Patch
Comment 6 WebKit Commit Bot 2014-09-29 20:24:20 PDT 
Attachment 238905 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2014-09-30 12:22:11 PDT 
Comment on attachment 238905 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2014-09-30 12:59:54 PDT 
Comment on attachment 238905 [details]
Patch

Clearing flags on attachment: 238905

Committed r174117: <http://trac.webkit.org/changeset/174117>
Comment 9 WebKit Commit Bot 2014-09-30 12:59:59 PDT 
All reviewed patches have been landed.  Closing bug.