Bug 137223

Summary: EWS is inconclusively spinning forever on a patch that breaks 500+ tests
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Jake Nielsen <jake.nielsen.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, glenn, jake.nielsen.webkit, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=138743
Attachments:
Description Flags
Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. none

Description Tim Horton 2014-09-29 12:27:48 PDT 
There's no way that EWS shouldn't be able to tell that the patch in https://bugs.webkit.org/show_bug.cgi?id=137164 breaks 500+ tests. But, it can't. See here: https://webkit-queues.appspot.com/patch/238809
Comment 1 Jake Nielsen 2014-10-01 13:15:51 PDT 
Created attachment 239043 [details]
Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red.
Comment 2 WebKit Commit Bot 2014-10-01 14:08:22 PDT 
Comment on attachment 239043 [details]
Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red.

Clearing flags on attachment: 239043

Committed r174170: <http://trac.webkit.org/changeset/174170>
Comment 3 WebKit Commit Bot 2014-10-01 14:08:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2014-10-01 14:37:21 PDT 
With this fix, will we have EWS spew the 500 failures into a Bugzilla comment?
Comment 5 Jake Nielsen 2014-10-01 16:23:13 PDT 
Crap, I forgot about that. Let me go check exactly what will happen.
(In reply to comment #4)
> With this fix, will we have EWS spew the 500 failures into a Bugzilla comment?