Bug 137213

Summary: Minor bug in UIClient::exceededDatabaseQuota()
Product: WebKit Reporter: Jinyoung Hur <hur.ims>
Component: WebKit2Assignee: Jinyoung Hur <hur.ims>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinyoung Hur
Reported 2014-09-29 07:24:42 PDT
completionHandler() should not be called more than once.
Attachments
Patch (1.92 KB, patch)
2014-09-29 07:50 PDT, Jinyoung Hur 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2014-09-29 18:03 PDT, Jinyoung Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinyoung Hur
Comment 1 2014-09-29 07:50:38 PDT
Created attachment 238853 [details] Patch
Anders Carlsson
Comment 2 2014-09-29 13:12:04 PDT
Comment on attachment 238853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238853&action=review > Source/WebKit2/ChangeLog:9 > + (WKPageSetPageUIClient): Patch looks great, but please fill in the ChangeLog, saying something like: "Make sure to not call the completion handler twice if exceededDatabaseQuota is null."
Jinyoung Hur
Comment 3 2014-09-29 18:03:47 PDT
Created attachment 238898 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-02 01:01:17 PDT
Comment on attachment 238898 [details] Patch Clearing flags on attachment: 238898 Committed r174204: <http://trac.webkit.org/changeset/174204>
WebKit Commit Bot
Comment 5 2014-10-02 01:01:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.