Bug 137175

Summary: [cairo] GraphicsContext should not depend on GTK+
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, gns, gyuyoung.kim, rakuco, ryuan.choi, sergio, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2014-09-27 03:56:03 PDT
There are some unused methods for GTK+2 and gdk_cairo_region() to render the focus ring. gdk_cairo_region iterates the rectangles of the region to call cairo_rectangle, so we can easily replace it.
Comment 1 Carlos Garcia Campos 2014-09-27 03:59:02 PDT
Created attachment 238771 [details]
Patch
Comment 2 Martin Robinson 2014-09-27 11:22:19 PDT
Comment on attachment 238771 [details]
Patch

Very nice.
Comment 3 Carlos Garcia Campos 2014-09-28 01:06:27 PDT
Committed r174041: <http://trac.webkit.org/changeset/174041>