Bug 137175 - [cairo] GraphicsContext should not depend on GTK+
Summary: [cairo] GraphicsContext should not depend on GTK+
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2014-09-27 03:56 PDT by Carlos Garcia Campos
Modified: 2014-09-28 01:06 PDT (History)
8 users (show)

See Also:

Patch (5.92 KB, patch)
2014-09-27 03:59 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-27 03:56:03 PDT
There are some unused methods for GTK+2 and gdk_cairo_region() to render the focus ring. gdk_cairo_region iterates the rectangles of the region to call cairo_rectangle, so we can easily replace it.
Comment 1 Carlos Garcia Campos 2014-09-27 03:59:02 PDT
Created attachment 238771 [details]
Comment 2 Martin Robinson 2014-09-27 11:22:19 PDT
Comment on attachment 238771 [details]

Very nice.
Comment 3 Carlos Garcia Campos 2014-09-28 01:06:27 PDT
Committed r174041: <http://trac.webkit.org/changeset/174041>