Bug 137167

Summary: Disable function.arguments
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, erights, ggaren, kangax, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, ossy, sam, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch for landing none

Filip Pizlo
Reported 2014-09-26 20:09:22 PDT
This disables function.arguments, but leaves the infrastructure to support it. We'll give it a while before we rip out that infrastructure. While the infrastructure is in the tree, you can enable it by setting JSC_enableFunctionDotArguments=true. It's also enabled for running JavaScriptCore stress tests.
Attachments
patch for landing (16.36 KB, patch)
2014-09-26 20:13 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-09-26 20:13:58 PDT
Created attachment 238756 [details] patch for landing RS=ggaren
Filip Pizlo
Comment 2 2014-09-27 13:28:35 PDT
Landed in http://trac.webkit.org/changeset/174036
Csaba Osztrogonác
Comment 3 2016-07-20 07:06:51 PDT
(In reply to comment #2) > Landed in http://trac.webkit.org/changeset/174036 http://trac.webkit.org/changeset/177029 reenabled function.arguments 20 moths ago. Do we still need this code path?
Csaba Osztrogonác
Comment 4 2016-07-20 07:17:14 PDT
And --useFunctionDotArguments=true is passed to all tests in RJST script when this option is always true 20 months ago. It seems to be redundant.
Note You need to log in before you can comment on or make changes to this bug.