Bug 137160

Summary: WKWebView should implement NSCoding
Product: WebKit Reporter: Quinn Taylor <qtaylor>
Component: WebKit APIAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dieter, mitz, mxn, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Quinn Taylor
Reported 2014-09-26 15:25:25 PDT
WKWebView should implement -encodeWithCoder: and -initWithCoder: to save and restore state, including the owned WKWebViewConfiguration. The existing -initWithCoder: returns nil, and doesn't call super. Among other uses, NSCoding support is required for use in Interface Builder. See radar://17380562 (WKWebView) and radar://18473221 (WKWebViewConfiguration).
Attachments
Patch (8.51 KB, patch)
2016-02-23 16:01 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-02-23 15:59:19 PST
Retitling - this now covers WKWebView.
Anders Carlsson
Comment 2 2016-02-23 16:01:48 PST
Created attachment 272060 [details] Patch
mitz
Comment 3 2016-02-23 16:19:13 PST
Comment on attachment 272060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272060&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:137 > + [a setMagnification:2.0]; 2
Anders Carlsson
Comment 4 2016-02-23 16:19:57 PST
Committed r197004: <http://trac.webkit.org/changeset/197004>
Note You need to log in before you can comment on or make changes to this bug.