Bug 137160

Summary:

WKWebView should implement NSCoding

Product:

WebKit

Reporter:

Quinn Taylor <qtaylor>

Component:

WebKit API

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, dieter, mitz, mxn, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Quinn Taylor 2014-09-26 15:25:25 PDT

WKWebView should implement -encodeWithCoder: and -initWithCoder: to save and restore state, including the owned WKWebViewConfiguration. The existing -initWithCoder: returns nil, and doesn't call super. Among other uses, NSCoding support is required for use in Interface Builder.

See radar://17380562 (WKWebView) and radar://18473221 (WKWebViewConfiguration).

Comment 1 Anders Carlsson 2016-02-23 15:59:19 PST

Retitling - this now covers WKWebView.

Comment 2 Anders Carlsson 2016-02-23 16:01:48 PST

Created attachment 272060 [details]
Patch

Comment 3 mitz 2016-02-23 16:19:13 PST

Comment on attachment 272060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272060&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:137
> +    [a setMagnification:2.0];

2

Comment 4 Anders Carlsson 2016-02-23 16:19:57 PST

Committed r197004: <http://trac.webkit.org/changeset/197004>