Bug 137160 - WKWebView should implement NSCoding
Summary: WKWebView should implement NSCoding
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Keywords: InRadar
Depends on:
Reported: 2014-09-26 15:25 PDT by Quinn Taylor
Modified: 2016-02-23 16:19 PST (History)
5 users (show)

See Also:

Patch (8.51 KB, patch)
2016-02-23 16:01 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Quinn Taylor 2014-09-26 15:25:25 PDT
WKWebView should implement -encodeWithCoder: and -initWithCoder: to save and restore state, including the owned WKWebViewConfiguration. The existing -initWithCoder: returns nil, and doesn't call super. Among other uses, NSCoding support is required for use in Interface Builder.

See radar://17380562 (WKWebView) and radar://18473221 (WKWebViewConfiguration).
Comment 1 Anders Carlsson 2016-02-23 15:59:19 PST
Retitling - this now covers WKWebView.
Comment 2 Anders Carlsson 2016-02-23 16:01:48 PST
Created attachment 272060 [details]
Comment 3 mitz 2016-02-23 16:19:13 PST
Comment on attachment 272060 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=272060&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:137
> +    [a setMagnification:2.0];

Comment 4 Anders Carlsson 2016-02-23 16:19:57 PST
Committed r197004: <http://trac.webkit.org/changeset/197004>