Bug 137149

Summary:

Mark fast/selectors/nth-child-of-basics as Slow

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Yusuke Suzuki

Reported 2014-09-26 09:57:35 PDT

fast/selectors/nth-child-of-basics takes long time

Attachments
Patch (1.69 KB, patch) 2014-09-26 10:02 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2014-09-26 10:02:01 PDT

Yusuke Suzuki

Comment 2 2014-09-26 10:07:04 PDT

Comment on attachment 238723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238723&action=review > LayoutTests/ChangeLog:11 > + [1]: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042 Actually, in my environment (GTK debug build), it takes about 50s and ran as expected. Is it better to split it into small tests that meet the timeout limit?

Benjamin Poulain

Comment 3 2014-09-26 12:24:43 PDT

(In reply to comment #2) > (From update of attachment 238723 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238723&action=review > > > LayoutTests/ChangeLog:11 > > + [1]: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042 > > Actually, in my environment (GTK debug build), it takes about 50s and ran as expected. > Is it better to split it into small tests that meet the timeout limit? I'll start on the JIT for it soon, maybe today. Let's mark it slow for now and I'll remove the expectation next week.

WebKit Commit Bot

Comment 4 2014-09-26 20:52:58 PDT

WebKit Commit Bot

Comment 5 2014-09-26 20:53:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.