Bug 137148

Summary: [GTK] Don't include full path names in WebKitEnumTypes.h
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gns, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Description Alberto Garcia 2014-09-26 09:22:55 PDT
In short, we should replace @filename@ with @basename@ here:

/*** BEGIN file-production ***/
/* Enumerations from @filename@. */
/*** END file-production ***/

The former puts the full path of the compilation directory in the generated file,
which should not be there, which among other things makes it more difficult to
have a multiarch-compliant header.
Comment 1 Alberto Garcia 2014-09-26 09:27:03 PDT
Created attachment 238722 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-26 09:28:22 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-09-26 09:30:58 PDT
(In reply to comment #0)
> In short, we should replace @filename@ with @basename@ here:
> 
> /*** BEGIN file-production ***/
> /* Enumerations from @filename@. */
> /*** END file-production ***/
> 
> The former puts the full path of the compilation directory in the generated file,
> which should not be there, which among other things makes it more difficult to
> have a multiarch-compliant header.

How does affect that multi-arch if it's just a comment?
Comment 4 Alberto Garcia 2014-09-26 09:48:22 PDT
(In reply to comment #3)
> How does affect that multi-arch if it's just a comment?

Multi-arch requires that all architecture-independent files are
identical among different architectures.

This file is architecture-indepent however it will be different among
builds if those builds are made in different directories.
Comment 5 Carlos Garcia Campos 2014-09-26 09:51:20 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > How does affect that multi-arch if it's just a comment?
> 
> Multi-arch requires that all architecture-independent files are
> identical among different architectures.
> 
> This file is architecture-indepent however it will be different among
> builds if those builds are made in different directories.

Ah, I see, thanks!
Comment 6 Alberto Garcia 2014-09-26 09:57:59 PDT
Committed r174008: <http://trac.webkit.org/changeset/174008>