Summary: | [EFL] Bump EFL version to 1.11.2 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tibor Mészáros <mtiborinf> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, ossy, ryuan.choi | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tibor Mészáros
2014-09-25 09:50:21 PDT
Created attachment 238661 [details]
Patch
Patch to bump EFL version to 1.11.2
Looks good to me. Comment on attachment 238661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238661&action=review LGTM > Tools/ChangeLog:3 > + Bump EFL version to 1.11.2 Please add [EFL] prefix. > Tools/ChangeLog:8 > + - Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler. Looks like we don't use - in ChangeLog. Comment on attachment 238661 [details]
Patch
LGTM me too.
Just 2 simple nit:
- Please make sure if everything will be OK on our ARM bots.
- Can we report the NEON issue to upstream? And we can pick
the patch and enable NEON again once it is fixed in the upstream.
Created attachment 238851 [details]
Patch v2
Updated patch.
(In reply to comment #5) > Created an attachment (id=238851) [details] > Patch v2 > > Updated patch. It looks you need to reply Ossy's questions before landing. (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=238851) [details] [details] > > Patch v2 > > > > Updated patch. > > It looks you need to reply Ossy's questions before landing. Of course, I'm going to try on our ARM bots, and I will report the NEON issue. Created attachment 238925 [details]
Patch v3
This patch has been tested on our ARM bots, and everything was fine.
Comment on attachment 238925 [details]
Patch v3
Cool, let's bump.
Comment on attachment 238925 [details] Patch v3 Clearing flags on attachment: 238925 Committed r174107: <http://trac.webkit.org/changeset/174107> All reviewed patches have been landed. Closing bug. |