RESOLVED FIXED 137118
[EFL] Bump EFL version to 1.11.2 
https://bugs.webkit.org/show_bug.cgi?id=137118
Summary [EFL] Bump EFL version to 1.11.2
Tibor Mészáros
Reported 2014-09-25 09:50:21 PDT
Bump EFL version to 1.11.2
Attachments
Patch (7.11 KB, patch)
2014-09-25 09:55 PDT, Tibor Mészáros 		gyuyoung.kim: review+
ossy: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (7.10 KB, patch)
2014-09-29 04:02 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Patch v3 (7.08 KB, patch)
2014-09-30 07:34 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tibor Mészáros
Comment 1 2014-09-25 09:55:06 PDT
Created attachment 238661 [details] Patch Patch to bump EFL version to 1.11.2
Ryuan Choi
Comment 2 2014-09-25 18:19:57 PDT
Looks good to me.
Gyuyoung Kim
Comment 3 2014-09-25 19:26:06 PDT
Comment on attachment 238661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238661&action=review LGTM > Tools/ChangeLog:3 > + Bump EFL version to 1.11.2 Please add [EFL] prefix. > Tools/ChangeLog:8 > + - Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler. Looks like we don't use - in ChangeLog.
Csaba Osztrogonác
Comment 4 2014-09-26 00:46:14 PDT
Comment on attachment 238661 [details] Patch LGTM me too. Just 2 simple nit: - Please make sure if everything will be OK on our ARM bots. - Can we report the NEON issue to upstream? And we can pick the patch and enable NEON again once it is fixed in the upstream.
Tibor Mészáros
Comment 5 2014-09-29 04:02:01 PDT
Created attachment 238851 [details] Patch v2 Updated patch.
Gyuyoung Kim
Comment 6 2014-09-29 04:42:04 PDT
(In reply to comment #5) > Created an attachment (id=238851) [details] > Patch v2 > > Updated patch. It looks you need to reply Ossy's questions before landing.
Tibor Mészáros
Comment 7 2014-09-29 05:11:32 PDT
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=238851) [details] [details] > > Patch v2 > > > > Updated patch. > > It looks you need to reply Ossy's questions before landing. Of course, I'm going to try on our ARM bots, and I will report the NEON issue.
Tibor Mészáros
Comment 8 2014-09-30 07:34:32 PDT
Created attachment 238925 [details] Patch v3 This patch has been tested on our ARM bots, and everything was fine.
Csaba Osztrogonác
Comment 9 2014-09-30 07:36:58 PDT
Comment on attachment 238925 [details] Patch v3 Cool, let's bump.
WebKit Commit Bot
Comment 10 2014-09-30 08:19:24 PDT
Comment on attachment 238925 [details] Patch v3 Clearing flags on attachment: 238925 Committed r174107: <http://trac.webkit.org/changeset/174107>
WebKit Commit Bot
Comment 11 2014-09-30 08:19:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.