| Summary: | Stop using legacy NODE_TYPE_CASTS() macro in svg/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | SVG | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, kling, koivisto, rniwa, zimmermann | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 137056 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2014-09-24 22:28:33 PDT
Created attachment 238644 [details]
Patch
Attachment 238644 [details] did not pass style-queue:
ERROR: Source/WebCore/svg/animation/SVGSMILElement.h:242: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGGraphicsElement.h:87: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGPolyElement.h:67: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGAnimateElement.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGTextContentElement.h:124: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h:87: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 6 in 40 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238644 [details] Patch Clearing flags on attachment: 238644 Committed r173970: <http://trac.webkit.org/changeset/173970> All reviewed patches have been landed. Closing bug. |