Bug 137106

Summary: Stop using legacy NODE_TYPE_CASTS() macro in svg/
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, koivisto, rniwa, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-09-24 22:28:33 PDT
Stop using legacy NODE_TYPE_CAST() in svg/ and use the new SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>() can be used for those types.
Attachments
Patch (45.30 KB, patch)
2014-09-24 23:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-24 23:42:27 PDT
Created attachment 238644 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-24 23:44:30 PDT
Attachment 238644 [details] did not pass style-queue: ERROR: Source/WebCore/svg/animation/SVGSMILElement.h:242: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/svg/SVGGraphicsElement.h:87: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/svg/SVGPolyElement.h:67: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/svg/SVGAnimateElement.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/svg/SVGTextContentElement.h:124: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h:87: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 6 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2014-09-25 10:25:50 PDT
Comment on attachment 238644 [details] Patch Clearing flags on attachment: 238644 Committed r173970: <http://trac.webkit.org/changeset/173970>
WebKit Commit Bot
Comment 4 2014-09-25 10:25:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.