Bug 137101

Summary: [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, mmaxfield
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Daniel Bates 2014-09-24 18:45:11 PDT
To satisfy clang, add case statement for kCLAuthorizationStatusAuthorized in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization], <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L95> and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:, <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L149>.
Comment 1 Daniel Bates 2014-09-24 18:46:28 PDT
Created attachment 238635 [details]
Patch
Comment 2 Mark Lam 2014-09-24 18:56:21 PDT
Comment on attachment 238635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238635&action=review

r=me with indentation fix.

> Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm:114
> +        case kCLAuthorizationStatusAuthorized:

Please fix this indentation.
Comment 3 Daniel Bates 2014-09-24 19:15:18 PDT
<rdar://problem/18449815>
Comment 4 Daniel Bates 2014-09-24 19:17:42 PDT
Committed r173940: <http://trac.webkit.org/changeset/173940>