Bug 137036

Summary: Have CSS classes' methods return more references
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-09-23 12:34:55 PDT
Have CSS classes' methods return more references instead of pointers.
Attachments
Patch (10.66 KB, patch)
2014-09-23 12:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.40 KB, patch)
2014-09-23 14:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-23 12:37:31 PDT
Created attachment 238558 [details] Patch
Chris Dumez
Comment 2 2014-09-23 14:48:25 PDT
Created attachment 238573 [details] Patch
Ryosuke Niwa
Comment 3 2014-09-23 18:04:17 PDT
Comment on attachment 238573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238573&action=review > Source/WebCore/inspector/InspectorStyleSheet.cpp:849 > - RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style()); > + RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style()); Can't we use Ref instead? > Source/WebCore/inspector/InspectorStyleSheet.cpp:932 > - RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style()); > + RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style()); Ditto.
WebKit Commit Bot
Comment 4 2014-09-23 18:45:46 PDT
Comment on attachment 238573 [details] Patch Clearing flags on attachment: 238573 Committed r173905: <http://trac.webkit.org/changeset/173905>
WebKit Commit Bot
Comment 5 2014-09-23 18:45:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.