Bug 137036

Summary: Have CSS classes' methods return more references
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2014-09-23 12:34:55 PDT 
Have CSS classes' methods return more references instead of pointers.
Comment 1 Chris Dumez 2014-09-23 12:37:31 PDT 
Created attachment 238558 [details]
Patch
Comment 2 Chris Dumez 2014-09-23 14:48:25 PDT 
Created attachment 238573 [details]
Patch
Comment 3 Ryosuke Niwa 2014-09-23 18:04:17 PDT 
Comment on attachment 238573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238573&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:849
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());
> +    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style());

Can't we use Ref instead?

> Source/WebCore/inspector/InspectorStyleSheet.cpp:932
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());
> +    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style());

Ditto.
Comment 4 WebKit Commit Bot 2014-09-23 18:45:46 PDT 
Comment on attachment 238573 [details]
Patch

Clearing flags on attachment: 238573

Committed r173905: <http://trac.webkit.org/changeset/173905>
Comment 5 WebKit Commit Bot 2014-09-23 18:45:51 PDT 
All reviewed patches have been landed.  Closing bug.