Summary: | Update HTMLMediaElement logging | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jer.noble | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-09-21 18:45:19 PDT
Created attachment 238443 [details]
Proposed patch.
Comment on attachment 238443 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=238443&action=review > Source/WebCore/html/HTMLMediaElement.cpp:673 > + LOG(Media, "HTMLMediaElement::removedFrom(%p)", this); I'd log this as HTMLMediaElement %p removedFrom", to make it clear that it's not an argument. Ditto elsewhere. (In reply to comment #2) > (From update of attachment 238443 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238443&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:673 > > + LOG(Media, "HTMLMediaElement::removedFrom(%p)", this); > > I'd log this as HTMLMediaElement %p removedFrom", to make it clear that it's not an argument. Ditto elsewhere. All "Media" logging uses this pattern. I don't think there is much danger of it being mistaken for an argument because only 'this' is in parenthesis, so I will leave it as is for now at least. Thanks for the review! Comment on attachment 238443 [details] Proposed patch. Clearing flags on attachment: 238443 Committed r173838: <http://trac.webkit.org/changeset/173838> All reviewed patches have been landed. Closing bug. |