| Summary: | build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, thorton, timothy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2014-09-19 16:55:08 PDT
Created attachment 238399 [details]
proposed fix
Comment on attachment 238399 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=238399&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:105 > - if (parsedDescription.firstChild.className === "changes") { > + if (parsedDescription.firstChild && parsedDescription.firstChild.className === "changes") { We may want to consider caching parsedDescription.firstChild in a local variable to avoid computing it again since we reference it four times in this function. Comment on attachment 238399 [details] proposed fix Clearing flags on attachment: 238399 Committed r173786: <http://trac.webkit.org/changeset/173786> All reviewed patches have been landed. Closing bug. |