Bug 136935

Summary: Optimize MarkupAccumulator::appendText()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-09-18 17:24:18 PDT
MarkupAccumulator::appendText() currently calls a generic MarkupAccumulator::appendNodeValue() method to append the text. This is the only caller for appendNodeValue() so we can inline the code in appendText() and make the code specific to Text nodes instead of supporting any kind of Node.
Attachments
Patch (4.86 KB, patch)
2014-09-18 18:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-18 18:17:56 PDT
Created attachment 238344 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-19 08:48:43 PDT
Comment on attachment 238344 [details] Patch Clearing flags on attachment: 238344 Committed r173754: <http://trac.webkit.org/changeset/173754>
WebKit Commit Bot
Comment 3 2014-09-19 08:48:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.