Bug 136935 - Optimize MarkupAccumulator::appendText()
Summary: Optimize MarkupAccumulator::appendText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-18 17:24 PDT by Chris Dumez
Modified: 2014-09-19 08:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.86 KB, patch)
2014-09-18 18:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-18 17:24:18 PDT 
MarkupAccumulator::appendText() currently calls a generic MarkupAccumulator::appendNodeValue() method to append the text. This is the only caller for appendNodeValue() so we can inline the code in appendText() and make the code specific to Text nodes instead of supporting any kind of Node.
Comment 1 Chris Dumez 2014-09-18 18:17:56 PDT 
Created attachment 238344 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-19 08:48:43 PDT 
Comment on attachment 238344 [details]
Patch

Clearing flags on attachment: 238344

Committed r173754: <http://trac.webkit.org/changeset/173754>
Comment 3 WebKit Commit Bot 2014-09-19 08:48:47 PDT 
All reviewed patches have been landed.  Closing bug.