Bug 136931

Summary:

Allow DOM methods to return references instead of pointers

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, commit-queue, kling, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2014-09-18 15:15:13 PDT

It is common practice in WebKit to have methods return a reference instead of a pointer if the pointer can never be null. However, this currently does not work for DOM methods (functions called by JS bindings), which is unfortunate. We should support this in order to use more references in the code base and for consistency. It is especially useful when DOM methods to be used in WebCore, in addition to the generated bindings.

Attachments
Patch (25.21 KB, patch) 2014-09-18 15:50 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.95 KB, patch) 2014-09-18 17:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.