RESOLVED FIXED136931
Allow DOM methods to return references instead of pointers 
https://bugs.webkit.org/show_bug.cgi?id=136931
Summary Allow DOM methods to return references instead of pointers
Chris Dumez
Reported 2014-09-18 15:15:13 PDT
It is common practice in WebKit to have methods return a reference instead of a pointer if the pointer can never be null. However, this currently does not work for DOM methods (functions called by JS bindings), which is unfortunate. We should support this in order to use more references in the code base and for consistency. It is especially useful when DOM methods to be used in WebCore, in addition to the generated bindings.
Attachments
Patch (25.21 KB, patch)
2014-09-18 15:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (25.95 KB, patch)
2014-09-18 17:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-18 15:50:29 PDT
Created attachment 238329 [details] Patch
Chris Dumez
Comment 2 2014-09-18 17:03:54 PDT
Created attachment 238336 [details] Patch
Sam Weinig
Comment 3 2014-09-19 10:05:51 PDT
Comment on attachment 238336 [details] Patch Cool.
WebKit Commit Bot
Comment 4 2014-09-19 11:33:23 PDT
Comment on attachment 238336 [details] Patch Clearing flags on attachment: 238336 Committed r173765: <http://trac.webkit.org/changeset/173765>
WebKit Commit Bot
Comment 5 2014-09-19 11:33:27 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 6 2014-09-19 12:27:13 PDT
(In reply to comment #3) > (From update of attachment 238336 [details]) > Cool. Very!
Note You need to log in before you can comment on or make changes to this bug.