Bug 136913

Summary: Incorrect pending API request URL when loading an HTML string
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136916    
Attachments:
Description Flags
Patch ap: review+

Carlos Garcia Campos
Reported 2014-09-18 01:27:45 PDT
The check to decide whether to use the given baseURL or about:blank is wrong there: String pendingAPIRequestURL = baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank"); It should be the opposite.
Attachments
Patch (1.49 KB, patch)
2014-09-18 01:29 PDT, Carlos Garcia Campos 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-09-18 01:29:48 PDT
Created attachment 238296 [details] Patch Trivial fix
Alexey Proskuryakov
Comment 2 2014-09-18 09:20:47 PDT
Comment on attachment 238296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238296&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:795 > + m_pageLoadState.setPendingAPIRequestURL(transaction, !baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank")); Nice. Can this be tested?
Alexey Proskuryakov
Comment 3 2014-09-18 09:22:55 PDT
Comment on attachment 238296 [details] Patch I see, it's tested in a patch for the bug blocked by this one.
Carlos Garcia Campos
Comment 4 2014-09-18 10:37:02 PDT
Committed r173726: <http://trac.webkit.org/changeset/173726>
Note You need to log in before you can comment on or make changes to this bug.