| Summary: | Incorrect pending API request URL when loading an HTML string | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, ap | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 136916 | ||||||
| Attachments: |
|
||||||
Created attachment 238296 [details]
Patch
Trivial fix
Comment on attachment 238296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238296&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:795 > + m_pageLoadState.setPendingAPIRequestURL(transaction, !baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank")); Nice. Can this be tested? Comment on attachment 238296 [details]
Patch
I see, it's tested in a patch for the bug blocked by this one.
Committed r173726: <http://trac.webkit.org/changeset/173726> |
The check to decide whether to use the given baseURL or about:blank is wrong there: String pendingAPIRequestURL = baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank"); It should be the opposite.