| Summary: | [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2014-09-17 14:57:12 PDT
Created attachment 238269 [details]
Patch
Attachment 238269 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:169: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 238271 [details]
Patch
Can this be tested? Not without a FairPlay key server. I'm working on a manual test, one that would use a internal key server. Comment on attachment 238271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238271&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:141 > + if (!initialized) { If you use "if (!sessionDirectoryPath.isEmpty())" you can lose the static bool. > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:147 > + sessionDirectoryPath.get().append("AVStreamSession/"); Should use ASCIILiteral. Committed r173791: <http://trac.webkit.org/changeset/173791> |