Bug 136898 – [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.

[Jer Noble]

Created attachment 238269 [details]
Patch

[WebKit Commit Bot]

Attachment 238269 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:169:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 238271 [details]
Patch

[Sam Weinig]

Can this be tested?

[Jer Noble]

Not without a FairPlay key server.

[Jer Noble]

I'm working on a manual test, one that would use a internal key server.

[Eric Carlson]

Comment on attachment 238271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238271&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:141
> +    if (!initialized) {

If you use "if (!sessionDirectoryPath.isEmpty())" you can lose the static bool.

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:147
> +        sessionDirectoryPath.get().append("AVStreamSession/");

Should use ASCIILiteral.

[Jer Noble]

Committed r173791: <http://trac.webkit.org/changeset/173791>

[Jer Noble]

<rdar://problem/19269042>