Summary: | Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cmarcelo, commit-queue, ggaren, graouts, joepeck, mark.lam, ossy, timothy, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-09-17 12:26:40 PDT
Created attachment 238316 [details]
[PATCH] Proposed Fix
Attachment 238316 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/Assertions.cpp:399: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WTF/wtf/Assertions.cpp:401: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 238316 [details] [PATCH] Proposed Fix Clearing flags on attachment: 238316 Committed r173731: <http://trac.webkit.org/changeset/173731> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > (From update of attachment 238316 [details]) > Clearing flags on attachment: 238316 > > Committed r173731: <http://trac.webkit.org/changeset/173731> It broke the Apple Windows, GTK and EFL build, please fix them. (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 238316 [details] [details]) > > Clearing flags on attachment: 238316 > > > > Committed r173731: <http://trac.webkit.org/changeset/173731> > > It broke the Apple Windows, GTK and EFL build, please fix them. Rolled out in r173736: <http://trac.webkit.org/changeset/173736>. Commit-queue beat the EWS bots. I'll address this using EWS to test. Reopening because this was rolled out. Created attachment 238332 [details]
[PATCH] For Bots 1
I will need the Win EWS to give me the new symbol name. This should fix style and EFL.
Attachment 238332 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 238341 [details]
[PATCH] For Bots 2
Windows bot failed without the patch. Trying Windows again.
Created attachment 238498 [details]
[PATCH] Proposed Fix
This should get things working for windows now.
Comment on attachment 238498 [details] [PATCH] Proposed Fix Clearing flags on attachment: 238498 Committed r173882: <http://trac.webkit.org/changeset/173882> All reviewed patches have been landed. Closing bug. The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes. (In reply to comment #15) > The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes. Doh! Thanks. Build fix for 64-bit Windows committed in r173900 <http://trac.webkit.org/changeset/173900>. |