Bug 136891

Summary: [GTK] Fix runtime critical warnings when writing to the clipboard after r173687
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo, pnormand, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2014-09-17 09:01:10 PDT
TEST: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=4979) /webkit2/WebKitWebView/cut-copy-paste/non-editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/cut-copy-paste/editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/select-all/non-editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/select-all/editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK PASS: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor
Attachments
Patch (1.94 KB, patch)
2014-09-17 09:03 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-09-17 09:03:52 PDT
Created attachment 238254 [details] Patch
Philippe Normand
Comment 2 2014-09-17 09:07:49 PDT
Comment on attachment 238254 [details] Patch LGTM!
Carlos Garcia Campos
Comment 3 2014-09-17 09:13:07 PDT
Committed r173692: <http://trac.webkit.org/changeset/173692>
Note You need to log in before you can comment on or make changes to this bug.