Bug 136891

Summary:

[GTK] Fix runtime critical warnings when writing to the clipboard after r173687

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, gustavo, pnormand, svillar

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review+

Description Carlos Garcia Campos 2014-09-17 09:01:10 PDT

TEST: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=4979)
  /webkit2/WebKitWebView/cut-copy-paste/non-editable:                  
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/cut-copy-paste/editable:                      
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/select-all/non-editable:                      
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed

(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/select-all/editable:                          
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed

(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
PASS: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor

Comment 1 Carlos Garcia Campos 2014-09-17 09:03:52 PDT

Created attachment 238254 [details]
Patch

Comment 2 Philippe Normand 2014-09-17 09:07:49 PDT

Comment on attachment 238254 [details]
Patch

LGTM!

Comment 3 Carlos Garcia Campos 2014-09-17 09:13:07 PDT

Committed r173692: <http://trac.webkit.org/changeset/173692>