Summary: | Remove unused methods from MediaPlayerClient | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, pnormand | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 21562 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-09-17 03:36:34 PDT
Created attachment 238247 [details]
Patch
Comment on attachment 238247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5664 > IntRect HTMLMediaElement::mediaPlayerWindowClipRect() > { > - return mediaPlayerOwningDocument()->view()->windowClipRect(); > + return document().view()->windowClipRect(); > } It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer. Committed r173719: <http://trac.webkit.org/changeset/173719> (In reply to comment #2) > (From update of attachment 238247 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:5664 > > IntRect HTMLMediaElement::mediaPlayerWindowClipRect() > > { > > - return mediaPlayerOwningDocument()->view()->windowClipRect(); > > + return document().view()->windowClipRect(); > > } > > It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer. Right, removed it as well. Thanks for the review. |