Bug 136884

Summary: Remove unused methods from MediaPlayerClient
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 21562    
Attachments:
Description Flags
Patch eric.carlson: review+

Description Carlos Garcia Campos 2014-09-17 03:36:34 PDT
It seems that some of the methods that introduce dependencies on WebCore types are actually unused.
Comment 1 Carlos Garcia Campos 2014-09-17 03:39:09 PDT
Created attachment 238247 [details]
Patch
Comment 2 Eric Carlson 2014-09-17 12:19:18 PDT
Comment on attachment 238247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5664
>  IntRect HTMLMediaElement::mediaPlayerWindowClipRect()
>  {
> -    return mediaPlayerOwningDocument()->view()->windowClipRect();
> +    return document().view()->windowClipRect();
>  }

It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer.
Comment 3 Carlos Garcia Campos 2014-09-18 04:16:38 PDT
Committed r173719: <http://trac.webkit.org/changeset/173719>
Comment 4 Carlos Garcia Campos 2014-09-18 04:17:26 PDT
(In reply to comment #2)
> (From update of attachment 238247 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:5664
> >  IntRect HTMLMediaElement::mediaPlayerWindowClipRect()
> >  {
> > -    return mediaPlayerOwningDocument()->view()->windowClipRect();
> > +    return document().view()->windowClipRect();
> >  }
> 
> It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer.

Right, removed it as well. Thanks for the review.