| Summary: | Add unprefixed flexbox display values and property names/values | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | Web Inspector | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2014-09-16 19:23:22 PDT
Created attachment 238234 [details]
Patch
Comment on attachment 238234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238234&action=review > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:365 > + "flex", "-webkit-flex", "inline-flex", "-webkit-inline-flex", "-webkit-grid", "-webkit-inline-grid" You can remove the prefixed versions. > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:675 > + "align-content": [ > + "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > + ], > "-webkit-align-content": [ > "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > ], All of these are identical! So the duplication is unnecessary. You should just remove the "-webkit-" prefix versions. Things will just work for prefixed and unprefixed autocompletion (see WebInspector.CSSKeywordCompletions.forProperty). Committed r173705: <http://trac.webkit.org/changeset/173705> |