Bug 136880

Summary: Add unprefixed flexbox display values and property names/values
Product: WebKit Reporter: Dean Jackson <dino>
Component: Web InspectorAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, dino: commit-queue-

Dean Jackson
Reported 2014-09-16 19:23:22 PDT
Add unprefixed flexbox display values and property names/values
Attachments
Patch (3.68 KB, patch)
2014-09-16 19:34 PDT, Dean Jackson 		benjamin: review+
dino: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-16 19:23:54 PDT
<rdar://problem/18361137>
Dean Jackson
Comment 2 2014-09-16 19:34:09 PDT
Created attachment 238234 [details] Patch
Joseph Pecoraro
Comment 3 2014-09-17 11:49:27 PDT
Comment on attachment 238234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238234&action=review > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:365 > + "flex", "-webkit-flex", "inline-flex", "-webkit-inline-flex", "-webkit-grid", "-webkit-inline-grid" You can remove the prefixed versions. > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:675 > + "align-content": [ > + "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > + ], > "-webkit-align-content": [ > "flex-start", "flex-end", "center", "space-between", "space-around", "stretch" > ], All of these are identical! So the duplication is unnecessary. You should just remove the "-webkit-" prefix versions. Things will just work for prefixed and unprefixed autocompletion (see WebInspector.CSSKeywordCompletions.forProperty).
Dean Jackson
Comment 4 2014-09-17 15:07:02 PDT
Committed r173705: <http://trac.webkit.org/changeset/173705>
Note You need to log in before you can comment on or make changes to this bug.