Bug 136874

Summary: [Win] __BUILD_NUMBER_SHORT__ not defined
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Alex Christensen <alex.christensen>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, bfulgham, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review-

Description Alex Christensen 2014-09-16 15:28:49 PDT
Recently when compiling WinCairo, I'm getting this error:
     1>..\..\win\WebKit.resources\WebKit.rc(51): error RC2104: undefined keyword or key name: __BUILD_NUMBER_SHORT__

I'm not sure why it's there, but getting rid of it fixes my problem.  Does it break anything else?
Comment 1 Alex Christensen 2014-09-16 15:31:03 PDT
Created attachment 238216 [details]
Patch
Comment 2 Brent Fulgham 2014-09-19 17:06:21 PDT
Comment on attachment 238216 [details]
Patch

__BUILD_NUMBER_SHORT_ should be created by auto-version.pl (and defined in "autoversion.h"). We don't want to make the change you propose. Most likely you just need to make sure auto-version.pl runs during the build to create the necessary autoversion.h file.
Comment 3 Ahmad Saleem 2024-03-10 19:20:32 PDT
If not mistaken this file is gone with: https://commits.webkit.org/260397@main

Marking this as 'RESOLVED CONFIGURATION CHANGED', please reopen, if I am wrong.