Bug 136856

Summary:

Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, lforschler, msaboff, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

126604, 131054, 136125

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2014-09-16 07:13:13 PDT

The original failure count introduced in:
https://trac.webkit.org/changeset/166608
https://trac.webkit.org/changeset/161461

And the http://trac.webkit.org/changeset/172829 tried to fixed 
the buggy failure counter, but it turned out it isn't enough, 
because the regexp should respect the 4 spaces at the beginning.

Comment 1 Csaba Osztrogonác 2014-09-16 07:25:16 PDT

Created attachment 238179 [details]
Patch

Comment 2 WebKit Commit Bot 2014-09-16 07:27:30 PDT

Attachment 238179 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157:  [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:160:  [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:163:  [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:178:  [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:181:  [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:184:  [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2014-09-18 10:15:14 PDT

Comment on attachment 238179 [details]
Patch

Clearing flags on attachment: 238179

Committed r173725: <http://trac.webkit.org/changeset/173725>

Comment 4 WebKit Commit Bot 2014-09-18 10:15:20 PDT

All reviewed patches have been landed.  Closing bug.