Bug 136842

Summary: Un-inline the Node constructor
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-09-15 16:11:53 PDT
Un-inline the Node constructor as it does not seem to impact performance: http://dromaeo.com/?id=226992,226998 This reduces the stripped binary size by ~4Kb.
Attachments
Patch (2.39 KB, patch)
2014-09-15 16:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2014-09-15 16:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-15 16:14:04 PDT
Created attachment 238145 [details] Patch
Benjamin Poulain
Comment 2 2014-09-15 16:48:32 PDT
Comment on attachment 238145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review > Source/WebCore/dom/Node.cpp:295 > + , m_parentNode(0) > + , m_treeScope(&document) > + , m_previous(0) > + , m_next(0) Let's take the opportunity to fix 0->nullptr.
Chris Dumez
Comment 3 2014-09-15 16:58:00 PDT
Created attachment 238149 [details] Patch
Chris Dumez
Comment 4 2014-09-15 16:58:22 PDT
Comment on attachment 238145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review >> Source/WebCore/dom/Node.cpp:295 >> + , m_next(0) > > Let's take the opportunity to fix 0->nullptr. Done.
WebKit Commit Bot
Comment 5 2014-09-15 18:15:46 PDT
Comment on attachment 238149 [details] Patch Clearing flags on attachment: 238149 Committed r173643: <http://trac.webkit.org/changeset/173643>
WebKit Commit Bot
Comment 6 2014-09-15 18:15:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.