Bug 136842 - Un-inline the Node constructor
Summary: Un-inline the Node constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-15 16:11 PDT by Chris Dumez
Modified: 2014-09-15 18:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2014-09-15 16:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2014-09-15 16:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-15 16:11:53 PDT 
Un-inline the Node constructor as it does not seem to impact performance:
http://dromaeo.com/?id=226992,226998

This reduces the stripped binary size by ~4Kb.
Comment 1 Chris Dumez 2014-09-15 16:14:04 PDT 
Created attachment 238145 [details]
Patch
Comment 2 Benjamin Poulain 2014-09-15 16:48:32 PDT 
Comment on attachment 238145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review

> Source/WebCore/dom/Node.cpp:295
> +    , m_parentNode(0)
> +    , m_treeScope(&document)
> +    , m_previous(0)
> +    , m_next(0)

Let's take the opportunity to fix 0->nullptr.
Comment 3 Chris Dumez 2014-09-15 16:58:00 PDT 
Created attachment 238149 [details]
Patch
Comment 4 Chris Dumez 2014-09-15 16:58:22 PDT 
Comment on attachment 238145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238145&action=review

>> Source/WebCore/dom/Node.cpp:295
>> +    , m_next(0)
> 
> Let's take the opportunity to fix 0->nullptr.

Done.
Comment 5 WebKit Commit Bot 2014-09-15 18:15:46 PDT 
Comment on attachment 238149 [details]
Patch

Clearing flags on attachment: 238149

Committed r173643: <http://trac.webkit.org/changeset/173643>
Comment 6 WebKit Commit Bot 2014-09-15 18:15:50 PDT 
All reviewed patches have been landed.  Closing bug.