Bug 136841

Summary: Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: CSSAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, hyatt, jonlee, mmaxfield, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 136484    
Bug Blocks:    
Attachments:
Description Flags
Patch hyatt: review+

Roger Fong
Reported 2014-09-15 15:02:46 PDT
In https://bugs.webkit.org/show_bug.cgi?id=136484 initial-letter support was enabled for Mac and iOS but not the other platforms. In order to enable we have to implement the cap height logic in SimpleFontDataWin. Until then, skipping all initial-letter tests
Attachments
Patch (1.94 KB, patch)
2014-09-22 11:28 PDT, Brent Fulgham 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-09-19 17:52:59 PDT
I'm testing a patch for this. Easy fix.
Brent Fulgham
Comment 2 2014-09-22 11:28:17 PDT
Created attachment 238489 [details] Patch
Radar WebKit Bug Importer
Comment 3 2014-09-22 11:29:24 PDT
<rdar://problem/18415046>
Dave Hyatt
Comment 4 2014-09-22 11:32:47 PDT
Comment on attachment 238489 [details] Patch r=me
Brent Fulgham
Comment 5 2014-09-22 11:35:37 PDT
Committed r173840: <http://trac.webkit.org/changeset/173840>
Note You need to log in before you can comment on or make changes to this bug.