Bug 136822

Summary: [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135606    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Grzegorz Czajkowski
Reported 2014-09-15 05:56:14 PDT
In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily initialized as we already does it in PlatformWebView::PlatformWebView calling ewk_init(). The reason for that was to ensure testing for example, WTF where creating the view is not mandatory. Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp in order to properly initalize and release EWebKit.
Attachments
Patch (3.73 KB, patch)
2014-09-15 05:57 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2014-09-15 05:57:35 PDT
Created attachment 238123 [details] Patch
Gyuyoung Kim
Comment 2 2014-09-15 07:08:58 PDT
Comment on attachment 238123 [details] Patch LGTM. r=me.
WebKit Commit Bot
Comment 3 2014-09-15 07:45:40 PDT
Comment on attachment 238123 [details] Patch Clearing flags on attachment: 238123 Committed r173621: <http://trac.webkit.org/changeset/173621>
WebKit Commit Bot
Comment 4 2014-09-15 07:45:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.