Bug 136820

Summary: Fix FindICU.cmake
Product: WebKit Reporter: Tibor Mészáros <mtiborinf>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Tibor Mészáros
Reported 2014-09-15 05:18:45 PDT
FindICU.cmake doesn't find headers and libraries when we cross compiled WebKit. But it works properly when I added pkg-config hints similar to other Find*.cmake scripts.
Attachments
Patch (1.08 KB, patch)
2014-09-15 05:23 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.38 KB, patch)
2014-09-15 05:24 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tibor Mészáros
Comment 1 2014-09-15 05:23:10 PDT
Created attachment 238120 [details] Patch Patch for this bug.
Tibor Mészáros
Comment 2 2014-09-15 05:23:56 PDT
Comment on attachment 238120 [details] Patch failed upload
Tibor Mészáros
Comment 3 2014-09-15 05:24:57 PDT
Created attachment 238121 [details] Patch v2 corrected patch file.
Csaba Osztrogonác
Comment 4 2014-09-16 01:20:21 PDT
Comment on attachment 238121 [details] Patch v2 r=me
WebKit Commit Bot
Comment 5 2014-09-16 01:57:22 PDT
Comment on attachment 238121 [details] Patch v2 Clearing flags on attachment: 238121 Committed r173655: <http://trac.webkit.org/changeset/173655>
WebKit Commit Bot
Comment 6 2014-09-16 01:57:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.