Bug 136820 - Fix FindICU.cmake
Summary: Fix FindICU.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-15 05:18 PDT by Tibor Mészáros
Modified: 2014-09-16 01:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.08 KB, patch)
2014-09-15 05:23 PDT, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Patch v2 (1.38 KB, patch)
2014-09-15 05:24 PDT, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-09-15 05:18:45 PDT 
FindICU.cmake doesn't find headers and libraries when we cross
compiled WebKit. But it works properly when I added pkg-config
hints similar to other Find*.cmake scripts.
Comment 1 Tibor Mészáros 2014-09-15 05:23:10 PDT 
Created attachment 238120 [details]
Patch

Patch for this bug.
Comment 2 Tibor Mészáros 2014-09-15 05:23:56 PDT 
Comment on attachment 238120 [details]
Patch

failed upload
Comment 3 Tibor Mészáros 2014-09-15 05:24:57 PDT 
Created attachment 238121 [details]
Patch v2

corrected patch file.
Comment 4 Csaba Osztrogonác 2014-09-16 01:20:21 PDT 
Comment on attachment 238121 [details]
Patch v2

r=me
Comment 5 WebKit Commit Bot 2014-09-16 01:57:22 PDT 
Comment on attachment 238121 [details]
Patch v2

Clearing flags on attachment: 238121

Committed r173655: <http://trac.webkit.org/changeset/173655>
Comment 6 WebKit Commit Bot 2014-09-16 01:57:26 PDT 
All reviewed patches have been landed.  Closing bug.