| Summary: | Remove shouldAbortEarly cruft from master.cfg | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Éva Balázsfalvi <evab.u-szeged> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dburkart, lforschler, matthew_hanson, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Éva Balázsfalvi
2014-09-12 05:09:34 PDT
Created attachment 238022 [details]
Patch
Comment on attachment 238022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238022&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-381 > - self.setCommand(self.command + ["--exit-after-n-crashes-or-timeouts", "50", "--exit-after-n-failures", "500"]) This line shouldn't be removed, we need --exit-after-* unconditionally. (shouldAbortEarly is always True) Created attachment 238126 [details]
Patch
This property was introduced in http://trac.webkit.org/changeset/126044 and the WTR bug was fixed by http://trac.webkit.org/changeset/126418 in 3 days. It happened 2 years before, since then we didn't need this hack to make bots not to exit early. So let's remove it. On a serious regression exit after 50 timeout is really necessary until the culprit patch is rolled out. 50 timeouts take 50*35s = 1750s = 29.16mins on WK1 and 50*80s = 66.66mins on WK2. If we disabled the early exit, it would cause infinite builds on the bots. If we will really need this hack in the future, I prefer adding it back as per builder configurable option, like SVNMirror. Comment on attachment 238126 [details] Patch Clearing flags on attachment: 238126 Committed r173653: <http://trac.webkit.org/changeset/173653> All reviewed patches have been landed. Closing bug. |