Bug 136720

Summary: [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
Product: WebKit Reporter: Adenilson Cavalcanti Silva <savagobr>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, fmalita, fpizlo, gyuyoung.kim, pdr, schenney, sergio, zimmermann
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Addressing the spaces issue. none

Adenilson Cavalcanti Silva
Reported 2014-09-10 15:48:30 PDT
Use some C++11 goodness to cleanup iterator loops.
Attachments
Patch (2.32 KB, patch)
2014-09-10 15:49 PDT, Adenilson Cavalcanti Silva 		no flags
DetailsFormatted DiffDiff
Addressing the spaces issue. (2.60 KB, patch)
2014-09-10 19:50 PDT, Adenilson Cavalcanti Silva 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adenilson Cavalcanti Silva
Comment 1 2014-09-10 15:49:46 PDT
Created attachment 237913 [details] Patch
Filip Pizlo
Comment 2 2014-09-10 19:32:41 PDT
Comment on attachment 237913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > + for (auto& it : m_scheduledAnimations) { There is something funky going on with indentation here - is that a hardware tab?
Filip Pizlo
Comment 3 2014-09-10 19:33:24 PDT
(In reply to comment #2) > (From update of attachment 237913 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > > > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > > + for (auto& it : m_scheduledAnimations) { > > There is something funky going on with indentation here - is that a hardware tab? Looks like spaces, but still, I think that this should be indented only 4 spaces.
Adenilson Cavalcanti Silva
Comment 4 2014-09-10 19:50:02 PDT
Created attachment 237928 [details] Addressing the spaces issue.
WebKit Commit Bot
Comment 5 2014-09-10 21:02:05 PDT
Comment on attachment 237928 [details] Addressing the spaces issue. Clearing flags on attachment: 237928 Committed r173506: <http://trac.webkit.org/changeset/173506>
WebKit Commit Bot
Comment 6 2014-09-10 21:02:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.