Summary: | [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adenilson Cavalcanti Silva <savagobr> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, d-r, fmalita, fpizlo, gyuyoung.kim, pdr, schenney, sergio, zimmermann | ||||||
Priority: | P4 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adenilson Cavalcanti Silva
2014-09-10 15:48:30 PDT
Created attachment 237913 [details]
Patch
Comment on attachment 237913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > + for (auto& it : m_scheduledAnimations) { There is something funky going on with indentation here - is that a hardware tab? (In reply to comment #2) > (From update of attachment 237913 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review > > > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191 > > + for (auto& it : m_scheduledAnimations) { > > There is something funky going on with indentation here - is that a hardware tab? Looks like spaces, but still, I think that this should be indented only 4 spaces. Created attachment 237928 [details]
Addressing the spaces issue.
Comment on attachment 237928 [details] Addressing the spaces issue. Clearing flags on attachment: 237928 Committed r173506: <http://trac.webkit.org/changeset/173506> All reviewed patches have been landed. Closing bug. |