Summary: | [GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, commit-queue, gustavo, gyuyoung.kim, mrobinson, pnormand, rakuco, ryuan.choi, sergio, svillar | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 136615 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-09-10 04:08:11 PDT
Created attachment 237885 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 237885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237885&action=review r=me > Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:58 > + We might consider doing this in one line. Committed r173510: <http://trac.webkit.org/changeset/173510> |