Bug 136700

Summary: [GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, gyuyoung.kim, mrobinson, pnormand, rakuco, ryuan.choi, sergio, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136615    
Attachments:
Description Flags
Patch svillar: review+

Description Carlos Garcia Campos 2014-09-10 04:08:11 PDT 
The only reason why we had this widget separated in WebCore was to share it between WebKit1 and WebKit2, but now it's only used by WebKitAuthenticationDialog. We can just merge it, and remove another unneeded file from WebCorePlatformGTK.
Comment 1 Carlos Garcia Campos 2014-09-10 04:13:27 PDT 
Created attachment 237885 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-10 04:15:18 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2014-09-11 01:03:04 PDT 
Comment on attachment 237885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237885&action=review

r=me

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:58
> +

We might consider doing this in one line.
Comment 4 Carlos Garcia Campos 2014-09-11 02:00:02 PDT 
Committed r173510: <http://trac.webkit.org/changeset/173510>