Bug 136698

Summary: [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
Product: WebKit Reporter: Tanay <tanay.c>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, gyuyoung.kim, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tanay
Reported 2014-09-10 02:15:36 PDT
Shift + Scroll in the browser should take the actions as follows: 1) User should navigate to previous webpage if he pressed Shift + Scroll Down direction 2) User should navigate to next webpage if he pressed Shift + Scroll Up direction
Attachments
Patch (3.17 KB, patch)
2014-09-10 02:22 PDT, Tanay 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2014-09-10 21:49 PDT, Tanay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tanay
Comment 1 2014-09-10 02:22:15 PDT
Created attachment 237883 [details] Patch
Gyuyoung Kim
Comment 2 2014-09-10 21:36:10 PDT
Comment on attachment 237883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237883&action=review > Tools/ChangeLog:3 > + Shift+Scroll navigate to back or forward url's Please add [EFL] prefix.
Tanay
Comment 3 2014-09-10 21:49:03 PDT
Created attachment 237930 [details] Patch
Gyuyoung Kim
Comment 4 2014-09-10 22:01:32 PDT
Comment on attachment 237930 [details] Patch It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me.
Tanay
Comment 5 2014-09-10 22:07:09 PDT
(In reply to comment #4) > (From update of attachment 237930 [details]) > It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me. Control + Scroll is the combination used for Zoom in current Web Browsers. We will support that too and upload in a separate patch.
WebKit Commit Bot
Comment 6 2014-09-10 23:41:13 PDT
Comment on attachment 237930 [details] Patch Clearing flags on attachment: 237930 Committed r173508: <http://trac.webkit.org/changeset/173508>
WebKit Commit Bot
Comment 7 2014-09-10 23:41:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.