Bug 136679

Summary: Make an UNREACHABLE() macro to wrap unreachable code, to reduce #if-iness
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: NEW    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Try to make it compile on non-clang platforms
none
Trying again to see if Windows builds bfulgham: review-

Maciej Stachowiak
Reported 2014-09-09 14:08:33 PDT
Make an UNREACHABLE() macro to wrap unreachable code, to reduce #if-iness
Attachments
Patch (15.61 KB, patch)
2014-09-09 14:11 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Try to make it compile on non-clang platforms (15.61 KB, patch)
2014-09-11 01:41 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Trying again to see if Windows builds (15.62 KB, patch)
2014-09-13 23:16 PDT, Maciej Stachowiak 		bfulgham: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2014-09-09 14:11:16 PDT
Created attachment 237855 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-09 14:12:37 PDT
Attachment 237855 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 3 2014-09-11 01:41:35 PDT
Created attachment 237943 [details] Try to make it compile on non-clang platforms
WebKit Commit Bot
Comment 4 2014-09-11 01:44:12 PDT
Attachment 237943 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 5 2014-09-13 23:16:15 PDT
Created attachment 238089 [details] Trying again to see if Windows builds
WebKit Commit Bot
Comment 6 2014-09-13 23:17:51 PDT
Attachment 238089 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 7 2014-09-13 23:57:19 PDT
Shouldn't we just remove the macros completely? The warning was removed, it was breaking random stuff.
Darin Adler
Comment 8 2014-09-14 13:43:22 PDT
Comment on attachment 238089 [details] Trying again to see if Windows builds Windows says “unable to build without patch”, so we need to fix the EWS.
Brent Fulgham
Comment 9 2016-03-14 11:39:34 PDT
Comment on attachment 238089 [details] Trying again to see if Windows builds Can you please update this patch for current sources? EWS should be functional now :-)
Note You need to log in before you can comment on or make changes to this bug.