Bug 136670

Summary: [GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
Product: WebKit Reporter: Rohit <kumar.rohit>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rohit
Reported 2014-09-09 07:28:11 PDT
Clean up WebKit GTK build from usused parameters. [5046/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:409:6: warning: unused parameter ‘type’ [-Wunused-parameter] void PageClientImpl::didSameDocumentNavigationForMainFrame(SameDocumentNavigationType type) ^ [5189/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/__/__/DerivedSources/WebKit2/WebPageMessageReceiver.cpp.o
Attachments
Patch (1.33 KB, patch)
2014-09-09 07:32 PDT, Rohit 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rohit
Comment 1 2014-09-09 07:32:40 PDT
Created attachment 237848 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-09 07:34:55 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2014-09-10 00:21:29 PDT
Comment on attachment 237848 [details] Patch Clearing flags on attachment: 237848 Committed r173455: <http://trac.webkit.org/changeset/173455>
WebKit Commit Bot
Comment 4 2014-09-10 00:21:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.