Bug 136670

Summary: [GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
Product: WebKit Reporter: Rohit <kumar.rohit>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Rohit 2014-09-09 07:28:11 PDT
Clean up WebKit GTK build from usused parameters.

[5046/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:409:6: warning: unused parameter ‘type’ [-Wunused-parameter]
 void PageClientImpl::didSameDocumentNavigationForMainFrame(SameDocumentNavigationType type)
      ^
[5189/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/__/__/DerivedSources/WebKit2/WebPageMessageReceiver.cpp.o
Comment 1 Rohit 2014-09-09 07:32:40 PDT
Created attachment 237848 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-09 07:34:55 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2014-09-10 00:21:29 PDT
Comment on attachment 237848 [details]
Patch

Clearing flags on attachment: 237848

Committed r173455: <http://trac.webkit.org/changeset/173455>
Comment 4 WebKit Commit Bot 2014-09-10 00:21:32 PDT
All reviewed patches have been landed.  Closing bug.