| Summary: | REGRESSION (r21363): Focus ring too tall | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hyatt | ||||
| Priority: | P1 | Keywords: | HasReduction, LayoutTestFailure, Regression | ||||
| Version: | 523.x (Safari 3) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| URL: | data:text/html,<div style="outline: auto"><pre><span><pre>foo</pre></span></pre></div> | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2007-05-10 15:58:17 PDT
Created attachment 14478 [details]
Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty
A block in the middle of a continuation should only include its collapsed margins if they aren't going to collapse beyond the inlines above/below.
This is covered by existing layout tests (even the test I added to fix the original bug showed this problem, I just didn't notice it), sigh.
This is purely a pixel issue, so isn't caught except by pixel layout tests.
Comment on attachment 14478 [details]
Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty
r=me!
Fixed |