Bug 136668

Summary: Add support for :read-write/:read-only matching editable content
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2014-09-09 00:04:10 PDT
Add support for :read-write/:read-only matching editable content
Attachments
Patch (72.32 KB, patch)
2014-09-09 00:23 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-09-09 00:23:45 PDT
Created attachment 237843 [details] Patch
Antti Koivisto
Comment 2 2014-09-09 13:00:04 PDT
Comment on attachment 237843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237843&action=review r=me > Source/WebCore/rendering/RenderTheme.cpp:843 > bool RenderTheme::isReadOnlyControl(const RenderObject& o) const With some more refactoring this could surely be turned into RenderElement& or something mores specific and the type check below eliminated...
Benjamin Poulain
Comment 3 2014-09-09 14:03:54 PDT
Comment on attachment 237843 [details] Patch Clearing flags on attachment: 237843 Committed r173441: <http://trac.webkit.org/changeset/173441>
Benjamin Poulain
Comment 4 2014-09-09 14:03:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.